Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/desktop/src-tauri/src/main.rs`:
- Around line 759-760: The error string returned when file selection is
cancelled is inconsistent with the frontend: in the load_project flow change the
.ok_or_else(...) result from "No file selected" to "User cancelled" (or
otherwise match the exact string checked in App.tsx) so that the check in
App.tsx suppresses the message; locate the pick_file() call inside load_project
and update its ok_or_else to return the frontend-expected "User cancelled"
message (or wrap into a shared constant if you prefer).
- Around line 755-763: The load_project function currently reads the entire file
without enforcing the documented 5MB limit; fix it by checking the picked file's
metadata.len() before calling std::fs::read_to_string and reject files larger
than 5 * 1024 * 1024 bytes with an Err message (e.g., "Project file exceeds 5MB
limit"). In practice, inside load_project use the PathBuf returned by
FileDialog::pick_file, call std::fs::metadata(path).map_err(...) to get size,
compare against a MAX_PROJECT_SIZE constant (5 * 1024 * 1024), and only proceed
to std::fs::read_to_string(path) and serde_json::from_str(&content) if the size
check passes; map any metadata/read errors to String as the function's Result
expects.

In `@apps/desktop/src/App.tsx`:
- Around line 133-139: Replace the forbidden console.error in handleSaveProject
with your app's logging/notification mechanism: catch the error from await
saveProject(jobResult!) and call the centralized logger (e.g., logger.error) or
show a user-facing error (e.g., showToast/showErrorModal) instead of
console.error; ensure you import/use the existing logging utility or
notification component and include the error details and context in the message
for saveProject failures.

In `@apps/desktop/src/features/workspace/SectionRoadmap.tsx`:
- Around line 28-32: handleChordEdit currently pushes a new harmony override
into targetRole.manualOverrides causing duplicate field:"harmony" entries;
instead, locate any existing ManualOverride with field === "harmony" for that
targetRole and replace it (or remove then add) so only one harmony override
exists per role—update the logic around targetRole.manualOverrides in
handleChordEdit to filter out or replace existing harmony entries before adding
the new override, referencing ManualOverride, targetRole, manualOverrides and
field:"harmony" to find and update the correct entry.

In `@apps/desktop/src/lib/analysis.ts`:
- Around line 171-173: The saveProject function currently forwards the incoming
RehearsalSong to invokeAnalysis without validation; update saveProject to
validate the input using the same parseRehearsalSong used by loadProject (call
parseRehearsalSong(song) or a dedicated validateRehearsalSong helper),
handle/throw on invalid data, and only call invokeAnalysis("save_project", {
payload: validatedSong }) when validation succeeds; reference saveProject,
parseRehearsalSong, loadProject and invokeAnalysis to locate and mirror the
existing response-validation pattern.

In `@docs/engineering/local-project-format.md`:
- Line 85: 파일 끝에 한 개의 개행 문자가 누락되어 markdownlint 경고가 발생하고 있으니 문서 끝(마지막 줄 끝)에 단일 개행
문자('\n')를 추가하여 파일을 종료하십시오; 변경 대상은 문서 내용에서 `.bscope`, `RehearsalSong`, 또는 포맷 버전
필드와 관련된 텍스트와 무관하게 파일의 마지막 바이트에 개행을 추가하는 것으로, 커밋 후 CI나 linter가 더 이상 경고를 내지 않는지
확인하세요.
- Line 79: The project loader lacks the documented 5MB limit: add a
MAX_PROJECT_SIZE constant (e.g. 5 * 1024 * 1024) in the backend and enforce it
inside the load_project function before deserializing - check file size via
std::fs::metadata(path).len() (or read with a capped reader) and return a clear
error if size > MAX_PROJECT_SIZE; only then proceed to read_to_string and
serde_json::from_str(&content). Ensure the new constant is exported/visible
where other backend code can reuse it so the documented constraint matches
implementation.

---

Outside diff comments:
In `@apps/desktop/src-tauri/src/main.rs`:
- Around line 690-708: The function declaration for get_analysis_job_status is
malformed and mixed into the tauri::generate_handler! macro; replace the stray
fragment "fn get_analysis_job_status," with a proper function definition
annotated with #[tauri::command] (e.g., fn get_analysis_job_status(job_id:
String, state: tauri::State<'_, AppState>) -> AnalysisJobStatus { ... }), move
it out of or before the tauri::generate_handler! invocation, and ensure the body
uses state.0.jobs.lock()... as shown (keeping the failed_status fallback) so the
function compiles and can be included in the handler list.

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/desktop/src-tauri/src/main.rs`:
- Around line 736-750: The save_project function currently returns Ok(()) when
the file dialog is cancelled, causing inconsistent behavior with load_project;
change save_project so that when FileDialog::save_file() yields None it returns
Err("User cancelled".to_string()) instead of Ok(()), keeping the function
signature Result<(), String> and matching the existing cancel handling in
load_project.

In `@apps/desktop/src/App.tsx`:
- Around line 135-137: The handler handleSaveProject uses a non-null assertion
on jobResult (await saveProject(jobResult!)) which can throw if jobResult
becomes null concurrently; fix by defensively checking and/or capturing
jobResult into a local const before the async call: inside handleSaveProject, do
const currentJob = jobResult; if (!currentJob) return (or show an error/disable
UI), then await saveProject(currentJob); this ensures saveProject never receives
a null value and avoids the runtime error.
- Line 82: The useEffect dependency includes t which changes each render because
createTranslator(detectPreferredLocale()) returns a new function reference;
stabilize it by memoizing the translator or by removing t from the effect deps
and extracting needed translated strings as constants. Specifically, wrap
createTranslator(detectPreferredLocale()) in useMemo (or a stable hook) so t
remains stable across renders, or compute const analysisCouldNotStart =
t("analysisCouldNotStart") outside the effect and remove t from the
useEffect([...jobStatus, t]) dependency list so the polling timer in the
useEffect that depends on jobStatus does not get recreated each render.

In `@apps/desktop/src/features/workspace/SectionRoadmap.tsx`:
- Around line 85-90: The highlighted clickable <strong> in SectionRoadmap.tsx
lacks keyboard support; update the element that displays role.harmony.chord so
it is keyboard-focusable and activates handleChordEdit(section.id, role) on
Enter/Space (or convert it to a semantic <button> with the same styling). Ensure
it has an accessible name (aria-label or visible text), respects the
onSongUpdate disabled state (prevent focus/activation when onSongUpdate is
false), and preserve the visual styles and role.harmony.source color logic;
implement key handling in the same component where handleChordEdit is used.

In `@apps/desktop/src/lib/analysis.ts`:
- Around line 171-174: The saveProject function is sending a wrapped payload ({
payload: parsedSong }) which mismatches the Rust save_project deserializer
expecting a RehearsalSongPayload at the top level; update saveProject to send
parsedSong directly (remove the payload wrapper) so
invokeAnalysis("save_project", ...) receives the RehearsalSongPayload shape
produced by parseRehearsalSong and will deserialize correctly in the Rust
handler.

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/desktop/src/features/workspace/SectionRoadmap.tsx`:
- Around line 11-12: SectionRoadmap currently calls
createTranslator(detectPreferredLocale()) on every render (variable t); memoize
the translator by computing the locale once (call detectPreferredLocale()) and
then wrap createTranslator(...) in React's useMemo with the locale as the
dependency so the translator is recreated only when the preferred locale
changes; update the SectionRoadmap component to use useMemo and reference
createTranslator, detectPreferredLocale, and the local t variable accordingly.

In `@registered_agents.json`:
- Line 1: The file registered_agents.json is unrelated to the PR and unused by
the codebase; either remove it from the PR or, if it was intentionally added,
add a brief documentation entry describing its purpose and integration plan and
why it belongs in the repo (reference the commit fca5fe8 as origin), and ensure
no code references it (search for registered_agents.json) before keeping it;
update the PR to delete the file or include the documentation and a short commit
message explaining its intended use.

In `@task_agent_mapping.json`:
- Line 1: task_agent_mapping.json is unused and contains only an empty JSON
object; either delete the file or keep it but document its purpose and schema
and reference where it will be used (e.g., update README/PR description) so
future maintainers know why it exists; if you keep it, add a clear JSON schema
example and usage notes inside the file or docs, and ensure the file ends with a
newline character.

---

Duplicate comments:
In `@apps/desktop/src/App.tsx`:
- Around line 135-145: The handler handleSaveProject should defensively guard
against jobResult becoming null/undefined during async execution; before calling
saveProject(jobResult) check that jobResult is non-null (or capture it into a
local const at function start) and return early (or setJobError appropriately)
if missing to avoid passing undefined to saveProject and potential runtime
errors; update the check inside handleSaveProject to use the local/captured
jobResult and bail out when it's falsy.

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/desktop/src/App.tsx`:
- Around line 126-145: The save/load handlers are writing transient save/load
failures into jobError which renderWorkspaceState treats as a blocking workspace
error; instead create and use a separate non-blocking state (e.g., saveLoadError
or setSaveError/setLoadError) for these UI errors and stop setting jobError in
handleSaveProject and the load path in the load handler; in each success path
clear the new non-blocking error (e.g., call setSaveError(undefined) or
setLoadError(undefined)); ensure renderWorkspaceState continues to rely on
jobResult/jobError for blocking analysis state and that the new save/load error
is shown separately so failures don't replace the open workspace.
- Around line 121-125: After successfully loading a project in the loadProject()
flow, you must also clear any prior file selection error so stale
"selectionError" UI state doesn't persist; update the success branch (around
setJobResult, setJobError, setSelectedBootstrap, setJobStatus) to call the state
updater that clears selection errors (e.g., setSelectionError(null) or
resetSelectionError()) so previous unsupported-audio errors are removed when a
project opens successfully.

In `@apps/desktop/src/features/workspace/SectionRoadmap.tsx`:
- Around line 17-18: Normalize the prompt result before validation: compute a
trimmed version (e.g., const normalized = newChord?.trim()) and use that
normalized value for the empty check and equality check against
role.harmony.chord, and then store normalized into the chord and
manualOverrides/source: "user" logic; update all occurrences in the block that
currently check newChord (and later save newChord.trim()) so they consistently
use the normalized variable to avoid recording overrides when only surrounding
whitespace changed.